Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version inconsistency #391

Open
1 task
bilal-fazlani opened this issue Nov 14, 2023 · 2 comments
Open
1 task

Version inconsistency #391

bilal-fazlani opened this issue Nov 14, 2023 · 2 comments
Labels
help wanted Extra attention is needed Maybe in Future

Comments

@bilal-fazlani
Copy link
Contributor

Describe the bug
After upgrading the plugin file with a newer version, Swiftbar runs the plugin file. But "About" section keeps showing older version

To Reproduce
Steps to reproduce the behavior:

  1. Start a plugin with version 1.0.0 version in streaming mode
  2. Replace the that plugin with a new one and with updated version 2.0.0
  3. Either "refresh" the plugin or disable and enable it again
  4. Notice the new plugin running
  5. Check the about section. It shows older version

Expected behavior
If the plugin is updated and new plugin is running, version should reflect that

Screenshots

image

image

Environment:

  • macOS version: 14.1 (23B74)
  • SwiftBar version: Version 2.0.0 (509)

Plugin Example:
Sample plugin to reproduce the issue, link or code.

Additional Context:

  • I have tested with streaming mode. No experience with normal mode
@melonamin
Copy link
Contributor

SwifrBar reads plugins metadata only during "plugin load" step. This is the step when SwiftBar detects the type of plugin, it's schedule and all other metadata.

Plugin load happens on first launch and on changes to plugin directory. It seems like that SwiftBar detects adding\removing files to the plugin directory, as well as file renames, but ignores file updates. That's why the version is not updated in the UI.

I'll check if I can make it react to all file changes.

@melonamin melonamin added Maybe in Future help wanted Extra attention is needed labels Dec 30, 2023
@melonamin
Copy link
Contributor

I spent about an hour trying to fix this, no luck. Not important enough to continue investing time in this, I'll keep it open if anyone would like to take a stub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Maybe in Future
Projects
None yet
Development

No branches or pull requests

2 participants