Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating CONTRIBUTING to require forking regardless of privileges #961

Open
maneesha opened this issue Aug 11, 2023 · 2 comments
Open

Comments

@maneesha
Copy link
Contributor

How could the content be improved?

The CONTRIBUTING document suggests contributing via a branch on your local copy of the repo, but does not say that it must be a fork. If we do want people to fork (regardless of GH privileges), as suggested in this comment, we should make that clear in the contributing guidelines -- along with reasons why forking is better than branching from the original source.

If this applies to all lesson repos across The Carpentries, we should move this to each organization's .github repo instead.

Whatever makes work easiest for contributors and maintainers alike is best!

@zkamvar
Copy link
Contributor

zkamvar commented Aug 11, 2023

@maneesha, having a global CONTRIBUTING would be good, but I don't think it's possible at the moment because while the contributing guide does apply generally to all of our lessons, they have repo-specific links in them and maintainers may have extra instructions that they wish to convey.

@maneesha
Copy link
Contributor Author

Thanks @zkamvar
I thought that might be so. In that case, this issue is just about whether we want people to contribute by forks, or if branches are acceptable for people with access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants