Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

vulkan: Remove hard dependency on validation layer #3283

Open
nyorain opened this issue Oct 20, 2021 · 0 comments · May be fixed by #3318
Open

vulkan: Remove hard dependency on validation layer #3283

nyorain opened this issue Oct 20, 2021 · 0 comments · May be fixed by #3318
Labels
renderer/vulkan renderer

Comments

@nyorain
Copy link
Contributor

nyorain commented Oct 20, 2021 •
edited by emersion

We currently require the validation layer in the vulkan renderer. If that is not installed, creating the renderer fails. While the validation layer is useful at the moment we probably don't want to abort because it's not installed and (sooner or later) we should disable it by default as it has a significant performance impact.

See 8e34692#commitcomment-58239638

wlroots has migrated to gitlab.freedesktop.org. This issue has been moved to:

https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3283
nyorain referenced this issue Oct 20, 2021
@nyorain @emersion @jbeich
render/vulkan: add Vulkan renderer
8e34692 
This new renderer is implemented with the existing wlr_renderer API
(which is known to be sub-optimal for some operations). It's not
used by default, but users can opt-in by setting WLR_RENDERER=vulkan.

The renderer depends on VK_EXT_image_drm_format_modifier and
VK_EXT_physical_device_drm.

Co-authored-by: Simon Ser <contact@emersion.fr>
Co-authored-by: Jan Beich <jbeich@FreeBSD.org>
@bl4ckb0ne bl4ckb0ne linked a pull request Oct 31, 2021 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
renderer/vulkan renderer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

render/vulkan: get only available validation layers bl4ckb0ne/wlroots
3 participants
@emersion @bl4ckb0ne @nyorain