Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer Shell regression: Layershell never releasing mouse again, once it is set to exclusive #7936

Open
feschber opened this issue Jan 26, 2024 · 8 comments · May be fixed by #8032
Open

Layer Shell regression: Layershell never releasing mouse again, once it is set to exclusive #7936

feschber opened this issue Jan 26, 2024 · 8 comments · May be fixed by #8032
Labels
bug Not working as intended
Milestone
1.10

Comments

@feschber
Copy link
Contributor

Setting the layershell keyboard interactivity to exclusive and then none makes it impossible to focus windows.
This must be a recent regression possibly related to the scene_graph api.

Might be related: #7918

  • Sway Version:
    • swaymsg -t get_version or sway -v

I tried to bisect but could not get an exact commit
it must be one of the following

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
188811f80861caacd016b857b0d07f6d2d62d15a
5b8b505af5d5925ae9e617ee8f3c7a0f9c43409d
6d7b1321db54155cf78305dbafdcfc7de9b78415
946fc8094559801bc4be629368ac31025d28165a
08c484f46f130aa7e590ef4bcb39d2ceed7160f6
869baff25221e1a1881e9559453faa43f90da33e
b38ed8b4792928dca3e1580e8160792ea41e25c4
bac3ab552683516ee5a09632468cd8de529d311f
6e5fc4c2aafd211323c6037aa868c075852bfe15
9a579666068d62b9354a39941e1ac8c1f4a58093
0639bde9fb5637fbe63c65bfe85660745f159b96
ed2724bd6c83ad3fdc2010b3a1e2f5967f0e8b38
06ad734e70227ad0527fe11b88ad37e93005ce0c
c640c3015f3a7ea2987bd7854d13ff282f90804f
1e018e72b4d57c8f354b9be9686a7a75797cdcab
9c17cba0b29979ae23c4521b884f7419fd558770
0e1a02bf0aad3d743985602b55043c5de019d1f0
5f0801b6f245cc789ea93b9449dd0c573ef36e66
2e53de80bb0f4c93e74ae050fa07e78f18e909d9
We cannot bisect more!
@feschber feschber added the bug Not working as intended label Jan 26, 2024
@feschber
Copy link
Contributor Author

So I did some more testing, and my suspicion seems to be confirmed by https://github.com/wmww/gtk-layer-shell

To reproduce the issue:

git clone https://github.com/wmww/gtk-layer-shell
cd gtk-layer-shell
meson setup -Dexamples=true build
ninja -C build
build/examples/gtk-layer-demo

Now setting keyboard from none to exclusive and back to none makes it impossible to focus any other window until either gtk-layer-demo or sway is killed.

@feschber
Copy link
Contributor Author

@Nefsen402 maybe you got an idea?
@emersion I hope this gets fixed before 1.9 is released. It could break a lot of applications

@emersion emersion added this to the 1.10 milestone Feb 14, 2024
@ackstorm23 ackstorm23 mentioned this issue Mar 2, 2024
Closed
@ackstorm23
Copy link

@feschber can you test this on Sway 1.9? the lan-mouse software KVM project cited this bug as a blocker for using their app, but the developer has tested with Sway 1.9 and not encountered the bug.

@Nefsen402 Nefsen402 linked a pull request Mar 2, 2024 that will close this issue
Open
@feschber
Copy link
Contributor Author

feschber commented Mar 3, 2024

but the developer has tested with Sway 1.9 and not encountered the bug.

That's me, I'm the developer ;)

@Nefsen402 has there been a change since release 1.9? I don't encounter this bug with sway 1.9 from the Arch repos.
I assumed it is still broken because this issue was not updated but from my testing the issue is not present in the release version.

@Nefsen402
Copy link
Contributor

has there been a change since release 1.9?

Yes, a large PR that rewrites and reworks all of sway's rendering code has landed in the current development version. This bug is a result of a regression the PR introduced.

@ackstorm23
Copy link

has there been a change since release 1.9?

Yes, a large PR that rewrites and reworks all of sway's rendering code has landed in the current development version. This bug is a result of a regression the PR introduced.

Did this bug not make it into 1.9, even though it appeared in git a week or more prior to 1.9's release?

@emersion
Copy link
Member

emersion commented Mar 3, 2024

The branch point for 1.9 has been created long before 1.9's first RC.

@WhyNotHugo
Copy link
Contributor

WhyNotHugo commented May 7, 2024 •
edited

I'm also seeing this as of 2686afb.

KeyboardInteractivity::OnDemand has the same behaviour.

I tried git bisect myself and my output is not any better:

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
188811f80861caacd016b857b0d07f6d2d62d15a
5b8b505af5d5925ae9e617ee8f3c7a0f9c43409d
6d7b1321db54155cf78305dbafdcfc7de9b78415
946fc8094559801bc4be629368ac31025d28165a
08c484f46f130aa7e590ef4bcb39d2ceed7160f6
869baff25221e1a1881e9559453faa43f90da33e
b38ed8b4792928dca3e1580e8160792ea41e25c4
bac3ab552683516ee5a09632468cd8de529d311f
6e5fc4c2aafd211323c6037aa868c075852bfe15
9a579666068d62b9354a39941e1ac8c1f4a58093
0639bde9fb5637fbe63c65bfe85660745f159b96
ed2724bd6c83ad3fdc2010b3a1e2f5967f0e8b38
06ad734e70227ad0527fe11b88ad37e93005ce0c
c640c3015f3a7ea2987bd7854d13ff282f90804f
1e018e72b4d57c8f354b9be9686a7a75797cdcab
9c17cba0b29979ae23c4521b884f7419fd558770
0e1a02bf0aad3d743985602b55043c5de019d1f0
5f0801b6f245cc789ea93b9449dd0c573ef36e66
2e53de80bb0f4c93e74ae050fa07e78f18e909d9
We cannot bisect more!

I think the issue comes from the switch to scene-graph, and that's probably all the information we can get out of bisection anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not working as intended
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

seat: Drop has_exclusive_layer Nefsen402/sway
5 participants
@emersion @WhyNotHugo @Nefsen402 @ackstorm23 @feschber