Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singleprompt weirdness if you accidentally scroll over it #827

Open
MediaResAchaea opened this issue May 13, 2023 · 3 comments
Open

Singleprompt weirdness if you accidentally scroll over it #827

MediaResAchaea opened this issue May 13, 2023 · 3 comments

Comments

@MediaResAchaea
Copy link

image

It's possible to hide the singleprompt by accidentally scrolling over it. In some cases, you can do this in a way that's subtle enough to not even be able to notice that you've done it, and you just think the Singleprompt vanished. Toggling it does not resolve this, only restarting Mudlet does.

I really don't understand the UI-y elements of Mudlet at the moment, so not sure if there's ~something we can do to prevent this from being able to happen, or to at least make toggling singleprompt bring it back?

Achaea discord convo: https://discord.com/channels/872599744793419776/872617984403857508/1106741471362686976

@MediaResAchaea
Copy link
Author

Ah, github doesn't like gifs: https://www.dropbox.com/s/pv1ss4fd8pjemip/Mudlet_POjo4KiZSS.gif?dl=0

@MediaResAchaea
Copy link
Author

Demonnic suggests: "it sounds like it's a miniconsole, in which case the answer to making it stop being scrollable is to put a transparent label overtop of it to intercept the mouse events."

@vadi2
Copy link
Contributor

vadi2 commented May 13, 2023

Will address this in Mudlet with Mudlet/Mudlet#6848, seen this to be an issue for players here and there.

vadi2 added a commit to Mudlet/Mudlet that referenced this issue May 31, 2023
<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Add an option to disable scrolling on miniconsoles
#### Motivation for adding to Mudlet
Address visible user pain point - some specialised miniconsoles don't
benefit at all from being scrollable, in fact it is a detriment to be
able to scroll them
#### Other info (issues closed, discussion etc)
Would help issues like svof/svof#827 and this:

![image](https://github.com/Mudlet/Mudlet/assets/110988/62d57ebb-f709-45a1-b296-d090b95ce865)

https://discord.com/channels/283581582550237184/283582068334526464/1098816505484955679.

Scrolling can't be disabled on the main window, that's largely not an
issue for players, and disabling scrolling there opens a can of worms.

API changes to test:
* `enableScrolling(window name)` - disables scrolling of a miniconsole
* `disableScrolling(window name)` - enables scrolling of a miniconsole

---------

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Co-authored-by: Damian <demonnic@gmail.com>
Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
Co-authored-by: eowmob <72653851+eowmob@users.noreply.github.com>
vadi2 added a commit to vadi2/Mudlet that referenced this issue Dec 24, 2023
<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Add an option to disable scrolling on miniconsoles
#### Motivation for adding to Mudlet
Address visible user pain point - some specialised miniconsoles don't
benefit at all from being scrollable, in fact it is a detriment to be
able to scroll them
#### Other info (issues closed, discussion etc)
Would help issues like svof/svof#827 and this:

![image](https://github.com/Mudlet/Mudlet/assets/110988/62d57ebb-f709-45a1-b296-d090b95ce865)

https://discord.com/channels/283581582550237184/283582068334526464/1098816505484955679.

Scrolling can't be disabled on the main window, that's largely not an
issue for players, and disabling scrolling there opens a can of worms.

API changes to test:
* `enableScrolling(window name)` - disables scrolling of a miniconsole
* `disableScrolling(window name)` - enables scrolling of a miniconsole

---------

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Co-authored-by: Damian <demonnic@gmail.com>
Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
Co-authored-by: eowmob <72653851+eowmob@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants