Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svof still making use of affliction triggers, should remove those #811

Open
TheLastDarkthorne opened this issue Mar 29, 2023 · 3 comments
Open

Comments

@TheLastDarkthorne
Copy link
Contributor

Basically title. GMCP affs are a thing for a good while now which means triggers do not need to exist except for the special/hidden afflictions (like Pariah latency, etc). While Svo has been working relatively well with gmcp affs detection and triggers coexisting, it is possible that at certain points it might cause overlap or make affliction detection weird somehow and might explain certain behaviors like all afflictions suddenly getting removed from customprompt upon a tree curing sometimes (reported by other users).

I'm creating this issue mostly for myself to check on later but anyone feel free to work on this

@tsartin
Copy link

tsartin commented Mar 29, 2023

I 100% agree. I know of at least one issue caused by this and possibly another. This will save time from building workarounds!

Do you want the triggers completely deleted or just the code removed from the triggers?

@tsartin
Copy link

tsartin commented Mar 29, 2023

Just a thought, and it would be pretty tedious, but some of these 'aff' triggers could be repurposed into class identifying triggers.

@tsartin
Copy link

tsartin commented Mar 30, 2023

Just a note, there are also a lot of temptriggers in setup that modify things that are/can be tracked via gmcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants