Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inrifting specific amounts of kelp causes precache to pull out more kelp #784

Open
codeacula opened this issue Oct 17, 2022 · 6 comments
Open

Comments

@codeacula
Copy link

codeacula commented Oct 17, 2022

  • Configure precache to keep out something (in this case, 2 kelp)
  • Harvest kelp
  • Inrift the specific number of kelp harvested
  • Precacher pulls out 2 more kelp
You are holding:
Corpses:
   The corpse of a sleek jaguar, the corpse of a dangerous water snake, and 2 corpses of an orc
guard.
Curing aids:
   3 dragon-carved rosewood pipes, a soot-blackened tinderbox, and 37 white oak vials.
Riftables:
   A group of 474 burdock roots, 3 pieces of kelp in 3 groups, and a group of 2 ginseng roots.
Weapons:
   An ornate heartwood fishing pole.
Containers:
   2 canvas backpacks.
Additional wearables:
   A pair of eagle's wings.
Misc:
   A marque of unquestioned seaworthiness, a memento of resolve, and a delicate clay cup.

You are wearing:
   a simple suit of rustic scale mail, a soft leopard-skin cloak, leaf-embroidered monk's robes of
cream silk, a pair of classy black trousers, a hunter's belt, Gloves of Harvesting, a Ceylonese 
ring, a Veil of the Sphinx, and a Ceylonese bracelet.
Weapon holders:
   an Eleusian ivy scabbard.
Containers:
   a canvas backpack.
--------------------------------------------------------------------------------
You have 501 gold.
5666h, 4466m, 20240e, 15385w excdbk 85.8- 08:54:15.802

plants
You're carried to the east by the river current.
Pachacacha nearing end of Savannah.
Rain pours down from dark thunderclouds, only the merest hints of sunset breaking through.
You see exits leading north, northeast, east, and west.
5666h, 4466m, 20240e, 15385w excdbk 85.8- 08:54:15.904
The following plants are growing in this room:
Some kelp (kelp)                             Sparse

harvest kelp
5666h, 4466m, 20240e, 15385w excdbk 85.8- 08:54:15.974
You reach out and carefully harvest 3 pieces of kelp.
inr 3 kelp
5666h, 4466m, 20235e, 15385w ecdbk 85.8- 08:54:16.046
You store 3 kelp, bringing the total in the rift to 400.
5666h, 4466m, 20235e, 15385w ecdbk 85.8- 08:54:16.115(outr 2 kelp)
You remove 2 kelp, bringing the total in the rift to 398.
5666h, 4466m, 20235e, 15385w ecdbk 85.8- 08:54:16.226
You have recovered balance on all limbs. (0.969s)
@tsartin
Copy link

tsartin commented Oct 20, 2022

So for this...

basically, there's no trigger to recognize that you gained 3 kelp from harvesting so when you inr the kelp it thinks you inr the 3 kelp you had precached.

The simple fix would be to add a trigger for harvesting and add a function to update your inventory count when you harvest. There are similar functions in the 'Rift' script that could be copied/modified.

The more advanced but probably better long-term fix would be to update the whole rift system to use gmcp. (might be a good bigger project outside the scope of this issue)

@codeacula
Copy link
Author

Is there already an effort underway for updating the rift system to gmcp?

@tsartin
Copy link

tsartin commented Oct 20, 2022

I don't believe so. We were working on tracking class info and balances via gmcp

@TheLastDarkthorne
Copy link
Contributor

Huh
Could swear svo had gmcp tracking for these items lol surprised it doesn't
Maybe it still uses the old stuff, there is a loooot of old things that could benefit some modernisation.

@tsartin
Copy link

tsartin commented Nov 7, 2022

@codeacula would you like me to add in these triggers?

@codeacula
Copy link
Author

@tsartin If you're already working on them. I've been trying to work around it, but figured that it would be handled with the GMCP stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants