Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monk->Bard Class swap #779

Open
Embrelle opened this issue Sep 30, 2022 · 5 comments
Open

Monk->Bard Class swap #779

Embrelle opened this issue Sep 30, 2022 · 5 comments

Comments

@Embrelle
Copy link

Swapping from Monk to Bard causes "[string "Script: Setup"]:431: attempt to index field 'tekura' (a nil value)" to appear on every line. A makeshift fix that's worked for me has been to change line 135 in the setup script from:
svo.sk = svo.sk or {}
to
svo.sk = {}
which has not caused any further issues thus far.

@tsartin
Copy link

tsartin commented Nov 7, 2022

@Embrelle Are you still having this issue? And if so, does it do this on a new profile?

@Embrelle
Copy link
Author

Embrelle commented Nov 7, 2022

@tsartin Yes, just tested with a fresh profile and the problem is still there. As a note for replication I've tried this with both Shikudo and Tekura monk, and the error message disappears after restarting mudlet but will come back if I switch to monk and then to bard.

@tsartin
Copy link

tsartin commented Nov 7, 2022

@Embrelle could you post a screen shot of what it looks like right after you change your class to bard? I'm trying to figure out where the switch is failing.

It should have something like
"(svof): Welcome back!
(svof): Loaded & ready to go, version 52 (homepage)
...etc"

@Embrelle
Copy link
Author

Embrelle commented Nov 7, 2022

image
@tsartin

@Embrelle
Copy link
Author

Embrelle commented Nov 7, 2022

@tsartin your proposed change, to add svo.signals.gmcpcharvitals = nil to svo.classchange resolved the problem!

tsartin added a commit to tsartin/svof that referenced this issue Nov 14, 2022
This helps overlapping signals from causing problems after a class change ( or anytime the system reinitializes)

Should solve svof#779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants