Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window scaling/DPI awareness problem #239

Open
AndrasMa opened this issue Dec 3, 2021 · 4 comments
Open

Window scaling/DPI awareness problem #239

AndrasMa opened this issue Dec 3, 2021 · 4 comments
Labels

Comments

@AndrasMa
Copy link

AndrasMa commented Dec 3, 2021

Starting the program, the window is scaling well on 4k (UHD, 3840*2160 px) displays, scaling set to 200% in display settings.
Upon loading an svg, the main window is reloading, and the scaling is not any more working, everything gets way too small to read.

To Reproduce
Steps to reproduce the behavior:

  1. Start grbl-plotter.exe
  2. Looks fine
  3. Click File/Open File...
  4. Load the bunny from examples
  5. Window reloads, lost scaling, everything is small.

Expected behavior
Scaling (DPI awareness, etc...) should remain the same as initial starting the program.

Screenshots
image

image

Workaround: Right click on exe, properties, compatibility page, modify high DPI setttings button, tick override, and select system (Extended)... (Sorry for non english windows language...)

image

@AndrasMa AndrasMa added the bug label Dec 3, 2021
@svenhb
Copy link
Owner

svenhb commented Dec 4, 2021

I can also observe the behavior, but after doing your workarround it seems to work - as you wrote...
I think it works for any further program start, problem solved - or not?
Would be nice to set this option (Override high dpi scaling) during install...

@AndrasMa
Copy link
Author

AndrasMa commented Dec 4, 2021

What happens during loading of saved files? May be it just needs to apply some flags, and settings for the main window.

Before loading it works fine, therefore upon first start scaling is all set up well. I've programmed just a little in Visual Studio C"anything" , so my memories are fading, but upon creating the window you have to set these things, and seems to be right.

May be the bug lies somewhere in UpdateWholeApplication() function (or SetGUISize()) in file GRBL-Plotter/GUI/MainFormUpdate.cs which is called when different INI files is selected.

@jem-green
Copy link

Workaround solves part of the problem but the rest of the scaling then breaks
image

@smakhtin
Copy link

I started the DPI PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants