{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":153484854,"defaultBranch":"main","name":"dicom","ownerLogin":"suyashkumar","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-10-17T15:58:48.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6299853?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1716864213.0","currentOid":""},"activityList":{"items":[{"before":"b290e170a9e75de831853c5afd4163be10121755","after":"bb750f079954f4e4b290cc6aed7bcb5e53e5ba9b","ref":"refs/heads/main","pushedAt":"2024-05-29T21:39:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Improve comment about magic word not present. (#318)","shortMessageHtmlLink":"Improve comment about magic word not present. (#318)"}},{"before":"a7f7bd4d622d8716cdf2f8e81e63fee86eb14e5f","after":"b290e170a9e75de831853c5afd4163be10121755","ref":"refs/heads/main","pushedAt":"2024-05-29T16:58:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Use innolitics DICOM Standard JSON dump to generate tags. (#316)\n\nThis PR is resolving #147.\r\n\r\nIt updates the generate_tag_definitions.py script to read the DICOM standard JSON dump from the Innolitics repo. They provide a few extra fields, so we introduce them in Tag definition, namely, Keyword and Retired. Keyword represents what Name used to represent, see comments on the field definitions for details.\r\n\r\nInnolitics also captures all possible VRs for tags that allow multiple VR values, so I updated the writer verification code to consider that. That ended up resolving #299 as well.\r\n\r\nThis is a breaking change because some tag variables have been deleted or renamed. In particular, the command tags (group 0000) have been all deleted since Innolitics doesn't provide them. I thought that was okay because these are only related to DIMSE and should never be present in a DICOM file. I can put them back somehow if you think we should keep them, but maybe we could sort that out if we ever work on #181. But mostly, tags were added or unchanged.\r\n\r\nI ended up writing this from scratch and not branching from #169 because I thought that was a little bit too complicated for this. But we could reconsider that design if there are requests for supporting private data dictionaries.\r\n\r\nMisc: fixes some warnings (i.e. removed deprecated ioutil, etc.), added a helper Uint32 method.","shortMessageHtmlLink":"Use innolitics DICOM Standard JSON dump to generate tags. (#316)"}},{"before":"eb06882086ba2359e3d2eb12812ca2f415a8ab15","after":"a7f7bd4d622d8716cdf2f8e81e63fee86eb14e5f","ref":"refs/heads/main","pushedAt":"2024-05-28T02:58:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Update to go1.22 (#317)","shortMessageHtmlLink":"Update to go1.22 (#317)"}},{"before":null,"after":"0f669b1f2543fe584394d2b04fb4afb775df5752","ref":"refs/heads/s/go122","pushedAt":"2024-05-28T02:43:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Update to go1.22","shortMessageHtmlLink":"Update to go1.22"}},{"before":"a69d754e273e2cd42185a2e8f5339f3b71113dcd","after":"01880ceb4298140eefc66c7cce8502e1fa3fb913","ref":"refs/heads/s/pixeldata-rep","pushedAt":"2024-05-27T04:14:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"go mod tidy","shortMessageHtmlLink":"go mod tidy"}},{"before":"77468ebc9e4bbfdc67e28ef579d1db43da121d61","after":"a69d754e273e2cd42185a2e8f5339f3b71113dcd","ref":"refs/heads/s/pixeldata-rep","pushedAt":"2024-05-27T04:13:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"passing tests (though more needed)","shortMessageHtmlLink":"passing tests (though more needed)"}},{"before":null,"after":"77468ebc9e4bbfdc67e28ef579d1db43da121d61","ref":"refs/heads/s/pixeldata-rep","pushedAt":"2024-05-27T03:59:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Initial hacking to explore multi-value native pixel data--still a lot of cleanup required and things to explore, tests to fix, things to rename, etc","shortMessageHtmlLink":"Initial hacking to explore multi-value native pixel data--still a lot…"}},{"before":"8847799ddd04f5820ddccebdccc220af11d9a1eb","after":"f60af73b7ca11e0e36517e726732e06b4fa46354","ref":"refs/heads/s/dataset-cache","pushedAt":"2024-05-27T02:02:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Add metadata elements to required context","shortMessageHtmlLink":"Add metadata elements to required context"}},{"before":"aee6b009dd34f356a0dc432876feac91cecbf0b9","after":"8847799ddd04f5820ddccebdccc220af11d9a1eb","ref":"refs/heads/s/dataset-cache","pushedAt":"2024-05-27T01:37:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"rename readElementWithContext","shortMessageHtmlLink":"rename readElementWithContext"}},{"before":"d8a75660737993b8a4a912814a90463a4abcfdaf","after":"aee6b009dd34f356a0dc432876feac91cecbf0b9","ref":"refs/heads/s/dataset-cache","pushedAt":"2024-05-27T01:36:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"rename readElementWithContext","shortMessageHtmlLink":"rename readElementWithContext"}},{"before":"82da81924db9872d299a0f27fa0c6623923de7db","after":"eb06882086ba2359e3d2eb12812ca2f415a8ab15","ref":"refs/heads/main","pushedAt":"2024-05-26T03:40:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Remove mocks (#312)","shortMessageHtmlLink":"Remove mocks (#312)"}},{"before":null,"after":"a29d7d2513dd6c62350b52e853c32809f8eb34c2","ref":"refs/heads/s/rm-mocks","pushedAt":"2024-05-26T03:38:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Remove mocks","shortMessageHtmlLink":"Remove mocks"}},{"before":"8f1f1517075e03fc3a3ec2463016177dad551ae8","after":"82da81924db9872d299a0f27fa0c6623923de7db","ref":"refs/heads/main","pushedAt":"2024-03-09T22:12:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"write: fix/support BigEndian PixelData writes, pad odd byte lengths with extra byte (#302)\n\n\r\n---------\r\n\r\nCo-authored-by: quang18 \r\nCo-authored-by: Suyash Kumar ","shortMessageHtmlLink":"write: fix/support BigEndian PixelData writes, pad odd byte lengths w…"}},{"before":"e41e1d037ed02df63d7ea3d08246eeaaa5888da6","after":"0f53fb47c2c27a2790cff8721af76698c33da548","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T05:13:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"add todo","shortMessageHtmlLink":"add todo"}},{"before":"d7ffe99a13905e3bfcf79f51a2c542296a7bf1ba","after":"e41e1d037ed02df63d7ea3d08246eeaaa5888da6","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T05:09:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"updates","shortMessageHtmlLink":"updates"}},{"before":"22805dab3d8ac9aebb96a0ad47876476653c2b89","after":"d7ffe99a13905e3bfcf79f51a2c542296a7bf1ba","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T05:07:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"some more updates","shortMessageHtmlLink":"some more updates"}},{"before":"5263e25193d1e69f7cf855ec9a1183a144200f27","after":"22805dab3d8ac9aebb96a0ad47876476653c2b89","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T04:58:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"some more tests","shortMessageHtmlLink":"some more tests"}},{"before":"f9d6b5f89d0f850e434870216959e908b1a7feb8","after":"5263e25193d1e69f7cf855ec9a1183a144200f27","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T04:51:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"some updates","shortMessageHtmlLink":"some updates"}},{"before":"75727e47a119986547104267ad4311d4e90deafd","after":"f9d6b5f89d0f850e434870216959e908b1a7feb8","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T04:27:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"additional quick updates","shortMessageHtmlLink":"additional quick updates"}},{"before":"8161503dcf63c3096b81db1167d6e11a368ecf60","after":"75727e47a119986547104267ad4311d4e90deafd","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T04:19:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"additional updates","shortMessageHtmlLink":"additional updates"}},{"before":"431a05951727005bdf2a3b45e2e0316748cd8555","after":"8161503dcf63c3096b81db1167d6e11a368ecf60","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T04:04:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"additional updates","shortMessageHtmlLink":"additional updates"}},{"before":"af0789d209f867d09f517f99b4606d7cb4504f2c","after":"431a05951727005bdf2a3b45e2e0316748cd8555","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T04:02:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"additional updates","shortMessageHtmlLink":"additional updates"}},{"before":"a87c2fa02b11ead85b944fa599fc7853b10ddfce","after":"af0789d209f867d09f517f99b4606d7cb4504f2c","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T03:54:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"minor updates","shortMessageHtmlLink":"minor updates"}},{"before":null,"after":"a87c2fa02b11ead85b944fa599fc7853b10ddfce","ref":"refs/heads/s/signed","pushedAt":"2023-11-06T03:45:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Return an error if Pixel Representation is signed and a signed native\npixel data value is found.","shortMessageHtmlLink":"Return an error if Pixel Representation is signed and a signed native"}},{"before":"e7dfaa40625eb17be94965a39add2e88b39e9dd8","after":"d8a75660737993b8a4a912814a90463a4abcfdaf","ref":"refs/heads/s/dataset-cache","pushedAt":"2023-11-05T23:14:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Add basic Parser.Next based benchmark","shortMessageHtmlLink":"Add basic Parser.Next based benchmark"}},{"before":"bd4070da73679ae6996be42f9cb49984c4516f8d","after":"e7dfaa40625eb17be94965a39add2e88b39e9dd8","ref":"refs/heads/s/dataset-cache","pushedAt":"2023-09-30T23:06:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Add basic Parser.Next based benchmark","shortMessageHtmlLink":"Add basic Parser.Next based benchmark"}},{"before":"593337178e6b642ac1922982fa1cf011fd1862cc","after":"8f1f1517075e03fc3a3ec2463016177dad551ae8","ref":"refs/heads/main","pushedAt":"2023-08-26T23:41:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Add Dataset & Element equality methods, greatly speeding up tests that rely on dataset comparisons. (#280)\n\nThis change introduces well-defined equality methods for Dataset, Element, and some other data structures. This greatly speeds up tests that rely on checking equality of datasets (that previously needed reflection). For example, it reduces the total test suite from 1m24s to 10s on GitHub actions (mostly due to one test). These methods may also be of use to library users.\r\n\r\nHowever, this does mean that if new fields are added to any of these structs it is important for the Equals method to be updated as well. For now this will be enforced during code review (helped by the fact most of these structs should not fail often), but we should investigate lint rules or some auto-generated reflection based tests that can help catch when this doesn't happen (see #281).\r\n\r\nThis change also makes a change to rely on pointers for []*frame.Frame in the PixelDataInfo.","shortMessageHtmlLink":"Add Dataset & Element equality methods, greatly speeding up tests tha…"}},{"before":"792e41b6000d56d47a0bdaba3829183dc81f2e69","after":"6a5c6a30bb820fcb57b3704b58741e47128863be","ref":"refs/heads/s/dataset-equality","pushedAt":"2023-08-26T23:36:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"nil updates, tests","shortMessageHtmlLink":"nil updates, tests"}},{"before":"3ec4a0718f15ad41bb721a63030a0e96f80cbd22","after":"792e41b6000d56d47a0bdaba3829183dc81f2e69","ref":"refs/heads/s/dataset-equality","pushedAt":"2023-08-26T23:32:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"docstrings, nil handling","shortMessageHtmlLink":"docstrings, nil handling"}},{"before":"9faf77f8f752c6ef29daae837f4bd15d9e5133d9","after":"3ec4a0718f15ad41bb721a63030a0e96f80cbd22","ref":"refs/heads/s/dataset-equality","pushedAt":"2023-08-26T23:03:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"suyashkumar","name":"Suyash Kumar","path":"/suyashkumar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6299853?s=80&v=4"},"commit":{"message":"Update dcmutil frame","shortMessageHtmlLink":"Update dcmutil frame"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEV2htbwA","startCursor":null,"endCursor":null}},"title":"Activity · suyashkumar/dicom"}