Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move django-after-response to optional? #25

Open
gsilvapt opened this issue Feb 15, 2023 · 1 comment
Open

Move django-after-response to optional? #25

gsilvapt opened this issue Feb 15, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request prioritize Items to prioritize

Comments

@gsilvapt
Copy link
Contributor

In this snippet, there's this FIXME comment here but, however, in #24 I tried moving this dependency to optional and some tests immediately failed, which made me wonder whether this dependency is that optional or not.

# FIXME: remove this "feature" (dependency)? move it to optional?

We should track the work necessary for this comment in this issue because it's definitely not just about moving the dependency around and updating docs.

@gsilvapt gsilvapt added enhancement New feature or request prioritize Items to prioritize labels Feb 15, 2023
@fopina
Copy link
Contributor

fopina commented Feb 15, 2023

If it was just moving to optional it would have been done instead of a FIXME 🧌

I think it's an old note in a sense of open question, whether this after_response should be dropped and only support run_async with a running dkron (that is the code that uses it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prioritize Items to prioritize
Projects
None yet
Development

No branches or pull requests

2 participants