expose redirect policy in Download

[victor-shepardson]

Motivation

Download doesn't follow redirects, so urls which work in a browser or with curl -L download as 0 bytes. In particular this affects downloads from github release pages.

Description of Proposed Feature

it looks straightforward to change the redirect policy in Qt: https://doc.qt.io/qt-6/qnetworkrequest.html#RedirectPolicy-enum

Could the Download class expose this option around here?

supercollider/QtCollider/QtDownload.cpp

Lines 67 to 70 in 28a0b12

	QUrl url = QUrl::fromEncoded(this->m_target.toLocal8Bit());
	QNetworkRequest request;
	request.setUrl(url);
	m_reply = m_manager->get(request);

[muellmusik]

Sounds reasonable. Would you propose setting 2 or 3 with a handler function?

Would you be comfortable creating a PR for this?

[victor-shepardson]

On second thought I wonder if it's worthwhile to expose the option, or if just setting it to 1 might be sufficient? This is apparently the default in Qt 6, but 0 is the default in Qt 5. Is any good reason for it to be 0 by default, or any reason to set it to 2?

https://doc.qt.io/qt-6/network-changes-qt6.html#redirect-policies

Happy to make PR when I find time, but I don't have a dev environment for SC set up at the moment. Maybe it's trivial for someone else in the meantime.