Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of resampling using reproject #427

Open
adwaitbhope opened this issue Jun 15, 2021 · 1 comment
Open

Implementation of resampling using reproject #427

adwaitbhope opened this issue Jun 15, 2021 · 1 comment

Comments

@adwaitbhope
Copy link
Contributor

Description

Expanding on #155.

NDCube should introduce a wrapper around reproject to implement resampling. As an initial implementation, the interpolation algorithm should be supported and the wrapper should be very thin. Later on, some of the parameters can be computed from data within the NDCube for simplicity.

This should apply to NDCubeSequence such that all the cubes are reprojected to the WCS of the first cube in the sequence, to get rid of the minor differences in the WCS of all cubes. The final WCS will need to be modified to include an extra dimension corresponding to the sequence.

The next step to follow could be trying to detect the invariant axes while resampling an NDCube. This would pave the way to perform resampling efficiently by reducing memory usage. It'll also help implement reproject's adaptive algorithm since it currently only supports resampling 2D arrays representing celestial axes.

Handling uncertainty and mask of an NDCube should also be taken care of, but it is not clear at the moment.

@DanRyanIrish
Copy link
Member

Hi @adwaitbhope. This looks like a good description of what we discussed. To help outline and track the work, I've created a GSOC Resampling project and broken down the initial implementation into a number of issues. If you reference the correct issue in the description of your PR, it should be automatically added to the project.

As you progress we can add more issues to this project to lay out the next steps in more detail. For now, I've broken the initial implementation of the NDCube.resample method into 2 issues, #428 and #429, and captured the use of that method by NDCubeSequence as #430.

@DanRyanIrish DanRyanIrish added this to To Do in NDCube Roadmap Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants