Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work properly with Bootstrap 5.2.3 and jQuery-3.7.1 #4603

Open
zakdma opened this issue Feb 6, 2024 · 3 comments
Open

Does not work properly with Bootstrap 5.2.3 and jQuery-3.7.1 #4603

zakdma opened this issue Feb 6, 2024 · 3 comments

Comments

@zakdma
Copy link

zakdma commented Feb 6, 2024

Using these links
https://cdn.jsdelivr.net/npm/summernote@0.8.20/dist/summernote-bs5.min.js
https://cdn.jsdelivr.net/npm/summernote@0.8.20/dist/summernote-bs5.min.css

At first, your module uses "jQuery" module name when jQuery is using the "jquery" (lowercase) module name by default for the very long time.
That forces us to use mapping when using require js or any other AMD module loader.
At second toolbar dropdowns don't work at all. It's because you use an incorrect attribute for bootstrap dropdowns.
Example your code

<button type="button" class="note-btn btn btn-light btn-sm dropdown-toggle" tabindex="-1" data-toggle="dropdown" aria-label="More Color" data-bs-original-title="More Color" aria-describedby="tooltip230312"></button>

It uses attribute data-toggle="dropdown" but should be data-bs-toggle="dropdown"

@DennisSuitters
Copy link
Member

Sadly, at the moment the version in cdn doesn't have the latest changes. If you require them, I suggest you build the project, and use the files from the created dist/ folder. At this time I have no ETA when the next release will occur.

@DennisSuitters
Copy link
Member

There is a PR open right now, however the changes causes a build error. I am waiting for the PR creator to amend the issues.
#4600

@ninjanerdbgm
Copy link

Hi, I created that PR. I accidentally closed it so I created a new one with changes that should fix the build errors:
#4604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants