Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version mismatch #38

Closed
wants to merge 2 commits into from
Closed

Fix version mismatch #38

wants to merge 2 commits into from

Conversation

uuuulopta
Copy link

Fixes #35

@kublaios
Copy link

kublaios commented Aug 7, 2023 •
edited

Edit: brew install mpv solved the issue. I thought pointing to the cloned repo in Cargo.toml would be enough.

=====

Thanks for the PR. When I'm trying to build the project on your PR, I get the following error (MacOS Ventura, cargo 1.68.1, do you know a fix for this?

$ cargo build --all --release
   Compiling libmpv-sys v3.1.0 (/Users/admin/Desktop/ytui/ytui-music/libmpv-rs/libmpv-sys)
   Compiling libmpv v2.0.1 (/Users/admin/Desktop/ytui/ytui-music/libmpv-rs)
   Compiling ytui_music v2.0.0-beta (/Users/admin/Desktop/ytui/ytui-music/front-end)
error: linking with `cc` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH="/Users/admin/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/bin:/Users/admin/.rbenv/shims:/Users/admin/.cargo/bin:..." VSLANG="1033" ZERO_AR_DATE="1" "cc" "-arch" "x86_64" "-m64" "/var/folders/rw/n1drw6wd0s57fctthd9gy4v80000gn/T/rustcsdM4bh/symbols.o" "/Users/admin/Desktop/ytui/ytui-music/target/release/deps/ytui_music-a5412eacd87b889b.ytui_music.35af069e-cgu.7.rcgu.o" "-L" "/Users/admin/Desktop/ytui/ytui-music/target/release/deps" "-L" "/Users/admin/Desktop/ytui/ytui-music/target/release/build/libsqlite3-sys-5f4d132f1788ad8a/out" "-L" "/Users/admin/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/var/folders/rw/n1drw6wd0s57fctthd9gy4v80000gn/T/rustcsdM4bh/liblibsqlite3_sys-409a77da88e7ffbd.rlib" "/Users/admin/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-6ab09b78d5863c75.rlib" "-lmpv" "-framework" "Security" "-framework" "CoreFoundation" "-liconv" "-lSystem" "-lc" "-lm" "-L" "/Users/admin/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "-o" "/Users/admin/Desktop/ytui/ytui-music/target/release/deps/ytui_music-a5412eacd87b889b" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: ld: library 'mpv' not found
          clang: error: linker command failed with exit code 1 (use -v to see invocation)


error: could not compile `ytui_music` due to previous error

@sudipghimire533
Copy link
Owner

Thank you so much for this @uuuulopta
Is it necesaary to have submodule tho? can we do with = { git = "", rev=""} instead?

@uuuulopta
Copy link
Author

@sudipghimire533 , Oh wow didn't know about that one. That certainly seems easier! We can either set it at the last commit, or set it on the main branch so it supports future versions of mpv. The crate itself hasn't been updated since 2020.

@sudipghimire533
Copy link
Owner

This however does not work right?

@sudipghimire533
Copy link
Owner

Again thank you very much uuuulopta, with your reference the issue had been fixed in latest commit. If you can confirm then this PR can be closed

@uuuulopta uuuulopta closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@uuuulopta @kublaios @sudipghimire533