Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 Support - Working #44

Open
Shanlon opened this issue Mar 26, 2018 · 3 comments
Open

Swift 4 Support - Working #44

Shanlon opened this issue Mar 26, 2018 · 3 comments

Comments

@Shanlon
Copy link

Shanlon commented Mar 26, 2018

Not sure the status on maintaining this pod, I moved it over to work on swift 4. I am willing to spend more time on it if there is interest.

I removed everything that was force unwrapped and made code changes.

https://github.com/Shanlon/SAConfettiView

@alfonsodev
Copy link

@Sanlon how could I use your fork from the time being until @sudeepag updates this package ?

@Shanlon
Copy link
Author

Shanlon commented Apr 25, 2018

@alfonsodev
If your using CocoaPods try: pod 'SAConfettiView', :git => 'https://github.com/Shanlon/SAConfettiView.git', :commit => 'c3d602ba939278d28cf7634d0cf5b38d113cd8d2'

@alfonsodev
Copy link

thanks @Shanlon, I can confirm your fork works on XCode 9.3 and Swift 4.1
Just one minor change, I had to replace

  confettiView.type = .Confetti

by

  confettiView.type = .confetti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants