Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 3.1 support #37

Open
saldous opened this issue Mar 28, 2017 · 2 comments
Open

Swift 3.1 support #37

saldous opened this issue Mar 28, 2017 · 2 comments

Comments

@saldous
Copy link

saldous commented Mar 28, 2017 •
edited

With xcode 8.3 and Swift 3.1 there are two minor build errors that need to be fixed as M_PI and M_PI_4 are deprecated.

In SAConfettiView.swift simply update:

confetti.emissionLongitude = CGFloat(M_PI)
confetti.emissionRange = CGFloat(M_PI_4)

to:

confetti.emissionLongitude = CGFloat(Double.pi)
confetti.emissionRange = CGFloat(Double.pi/4)
@saldous
Copy link
Author

saldous commented Apr 5, 2017

I created a pull request with this update: #38

@onmyway133
Copy link

@saldous Hi, in the meantime you can use https://github.com/hyperoslo/Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onmyway133 @saldous