Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confetti doesn't stop #12

Open
clrung opened this issue Apr 13, 2016 · 2 comments · May be fixed by #13
Open

Confetti doesn't stop #12

clrung opened this issue Apr 13, 2016 · 2 comments · May be fixed by #13

Comments

@clrung
Copy link

clrung commented Apr 13, 2016

Hello! I love this effect–great job! I use this pod In my Obj-C app, and when I call

[_confettiView stopConfetti];

The confetti doesn't stop. I tried putting it in viewDidLoad, but it still didn't work. Any ideas? Thank you!
@clrung
Copy link
Author

clrung commented Apr 18, 2016

I'll revise; if [_contettiView startConfetti] is called more than once, repeated [_confettiView stopConfetti] calls do not stop the confetti.

@clrung clrung linked a pull request Apr 18, 2016 that will close this issue
Open
@clrung
Copy link
Author

clrung commented Apr 19, 2016

This check is necessary because if the confettiView is started more than once, it will never be able to be stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added check to make sure confetti only starts once clrung/SAConfettiView
1 participant
@clrung