Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mac addr checks disabled by default and add parameter to turn on #141

Open
jadilet opened this issue Jan 22, 2019 · 3 comments
Open

Comments

@jadilet
Copy link
Contributor

jadilet commented Jan 22, 2019

@akarasulu commented on Sat Jan 13 2018

Right now the default is to check for mac addresses on the network after creating a random mac address to be absolutely certain that no other machine has the same mac address on the network.

This is not always needed. I do not think this should be enabled for the simple default case. There should be a parameter to turn this feature on like MAC_CHECK which can be either true or false. The default should be false.

jadilet added a commit that referenced this issue Jan 22, 2019
implemented default do not check mac addr #141
@akarasulu
Copy link
Contributor

@jadilet I agree with the MAC_CHECK but perhaps name it something more clear like ENABLE_MAC_CHECK ... boolean parameter is clear.

@jadilet
Copy link
Contributor Author

jadilet commented Jan 23, 2019

Got it, I will change the configuration parameter to ENABLE_MAC_CHECK.

@Almansherov
Copy link
Member

Implemented in master:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants