Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Provide a way to re-compile currently active overlays #191

Open
devsk opened this issue Dec 29, 2018 · 23 comments
Open

Provide a way to re-compile currently active overlays #191

devsk opened this issue Dec 29, 2018 · 23 comments

Comments

@devsk
Copy link

devsk commented Dec 29, 2018

From inside the Manager or within a theme, I want the ability to quickly re-compile all active overlays that I am using with the same set of options I have currently selected.

This is not possible today. The only thing I can do is "Enable installed overlays" from within theme view, but the task is to re-compile overlays because the apps got updated a bit and we need to recompile.

Most of the times I forget which options I had selected when I got my perfect combo of overlays working. The options get reset to their defaults as soon as I enter the theme specific view. So, I can't really rebuild my current perfect combo of overlays with the current set of options.

This has led to a lot of pain for me figuring out the combo's again after I updated the apps from play store and needed a rebuild. And even after fiddling for hours, I can't get the themes to show up as original perfect combo.

@djdarkknight96
Copy link

djdarkknight96 commented Dec 29, 2018

Easy..make notes of overlays...take screenshot of them. Save profiles. Many other ways then adding more to subs.

@devsk
Copy link
Author

devsk commented Dec 29, 2018

Hey dj, good to see you here.

I think "Build installed overlays" should be a native button along with "Enable installed overlays" for ease of use. It will take all the confusion and mess out of it. Particularly, in themes where there are lot of options to select to get your perfect themes. Doing it manually is very cumbersome!

@djdarkknight96
Copy link

But has been working fine without any complaints from my users and I have a ton of options. I have a group that I help with selecting correct options and customer service as well. Many theme devs do this already so I don't think we need anything added to substratum. From a theme devs perspective. We have asked the substratum devs for features we needed and they already added them. We have a nice system already so I'm not sure we would need anything else.

@devsk
Copy link
Author

devsk commented Dec 29, 2018

Isn't it easier to do it automatically with a single click instead of manually recording the option with screenshots and applying each one manually?

Why would you want to babysit users when they can just click one button and rebuild their current selections automatically?

@devsk
Copy link
Author

devsk commented Dec 29, 2018

And its not like there is a whole of work needed in subs to do this. All the pieces are already there. Its just one UI element and putting some code pieces together.

@gcantoni
Copy link
Contributor

As @djdarkknight96 said, profiles are a good way to do what you are looking for

@devsk
Copy link
Author

devsk commented Dec 29, 2018

That's what I tried. Restoring profiles does not rebuild my saved selections. It just enables them if they are already built. That's not what I am looking for.

If you force profiles to rebuild every time I restore, then yes, it would satisfy my requirements.

@djdarkknight96
Copy link

If it's easy then add a commit and see if you really think it's easy to do. Also there is already an automatic overlay refresher but if we use type3 it won't work. So this won't either.

@devsk
Copy link
Author

devsk commented Dec 29, 2018

@dj: I am a developer myself and I could take you on that challenge if my startup had me left any time. Learning the code from beginning is what would be the hard part for me. But for someone who is playing in this area, it should be a rehash of few code pieces. Sure, I don't know the subs code, so I am just making an educated guess from what feature I know are already there.

@devsk
Copy link
Author

devsk commented Dec 29, 2018

May be instead of a feature request, I should make it a bug report against profiles feature, where it should always rebuild and enable all overlays from the profile and not just enable them.

@djdarkknight96
Copy link

Again still have the issue with type3 and changes to them as well. Users just need to go back to theme list and build updates. Been working fine like this and making anything automated still has to go thru the issue at hand. Adding options on updates won't be built and users will complain apps crash. The process we have works so no need to improve. If users want themes they can learn the process.

@devsk
Copy link
Author

devsk commented Dec 29, 2018

If we never made things easier than they currently are, we would be still living in caves and hunting deers for food...:-)

@djdarkknight96
Copy link

Lazier not easier

@devsk
Copy link
Author

devsk commented Dec 29, 2018

I still don't get how a single button (whether a new UI element or profiles fixed) doing the right thing is "not easier" than fiddling with all the options and 30 different apps settings?

Its not about being lazy...its about how much time I, the end user, am willing to spend on updating my themes when app updates flow in.

@djdarkknight96
Copy link

djdarkknight96 commented Dec 29, 2018

Again, complex themes with type3 will not build this way. And if something changes like added versions won't build then user is going to theme list anyways. It's not feasible.

@devsk
Copy link
Author

devsk commented Dec 29, 2018

It's not feasible.

Famous last words from every failing enterprise...:-)

Everything is feasible my friend. We just haven't found a way yet.

@4PERTURE
Copy link

@devsk lol

@4PERTURE
Copy link

@4PERTURE oh sorry about this i was laughing at this and replied accidentally through the telegram bot

@takarushi
Copy link

@4PERTURE you're amazing and my opinion doesn't matters

@4PERTURE
Copy link

@Ni1xx thanks love you too (btw i didnt even give an opinion but k lol)

@devsk
Copy link
Author

devsk commented Dec 30, 2018

One more option we can implement: persist the selections in the theme viewer/builder from last time. That way I don't have to choose anything. I select all and "Build & Update", reboot, done!

@androidacy-user
Copy link

androidacy-user commented Mar 5, 2019

This would be WAY easier than my current methods: pick options at random until I hit the right mix. I regularly go through and delete crappy of my phone, like picture so screenshot would not help. Pen and paper tends to disappear around me.
The real question is: someone is lazy, but who? End user or devs?

Sent from my TETRA using FastHub

@androidacy-user
Copy link

I wonder if ROMs with sysserv make this any easier......

My best suggestion is to remember all options, and when importing a profile it auto selects (and normally) remembers all your options, so a theme update is select all - > build - > reboot (if on a ROM that needs it)

I mean the main app already remembers the Android version up top, just needs to remember more options. Try updating your Flow or theme lol. (Theme with many, many, many options

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants