Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No new ghost saved after deleting the best one #156

Open
michael-heerdegen opened this issue Nov 11, 2023 · 15 comments
Open

No new ghost saved after deleting the best one #156

michael-heerdegen opened this issue Nov 11, 2023 · 15 comments

Comments

@michael-heerdegen
Copy link

Hello,

What happened?

I drive OT and use the setting to only save and keep the best ghost for any track.

I had once driven Glacier (actual track doesn't matter) and had used turbo in my best race. I now always want to drive without turbo (an old truck doesn't have a turbo, so it feels more natural without), but I could not beat that old ghost record. So (from inside the game) I just deleted that ghost. Worked as expected so far.

But after that (bug) no other ghost would ever be recorded. It took a while for me to find that the cause was that the file
"data/stuntrally/records/normal/Wnt11-Glacier.txt" still had the best time that belonged to that ghost. With an editor I changed that time manually to a very large value, and the next time I played Glacier the ghost was recorded, and in the next game the ghost was finally shown as expected.

Dunno how hard it is to fix or improve the behavior for this case, but if it is not that hard, I would be happy if the handling of this situation could be improved.

Thank you very much!

@cryham
Copy link
Member

cryham commented Nov 11, 2023

Hi
Okay so deleting ghost in game should also remove its track record from that .txt
Yes, this was so since the begining. Will need some extra code.

@cryham
Copy link
Member

cryham commented Nov 12, 2023

Technically it should be possible to save any ghost regardless of time, if you checked that option on Replay - View tab, Save ghost only for best time. But I didn't test it since a while.
But yeah I should add an option to delete time records when deleting ghost. IDK how rarely I did it from Gui.

@michael-heerdegen
Copy link
Author

michael-heerdegen commented Nov 13, 2023 via email

@michael-heerdegen
Copy link
Author

michael-heerdegen commented Nov 16, 2023 via email

@cryham
Copy link
Member

cryham commented Nov 16, 2023

It's not possible now, but since you asked, I will setup a Patreon and reply here when done.

@cryham
Copy link
Member

cryham commented Nov 16, 2023

Okay after some research I decided to setup Ko-fi,
It is now available here: https://ko-fi.com/cryham
It has less fees and also supports monthly donations.

@michael-heerdegen
Copy link
Author

Great thank you very much will have a look very soon at ko-fi..

@michael-heerdegen
Copy link
Author

BTW, another low hanging fruit in the UI involving ghosts that might give lots of users an improvement: currently there is a minimum distance option - when the ghost is nearer, it is not shown in the game and the minimap. It might be cool if one could control the minimap and the game separately: In-game a very close ghost is annoying, but in the minimap it is not, at least not to that extent.

@michael-heerdegen
Copy link
Author

ko-fi looks appropriate, Terms of Service also look ok to me. It was simple to set up donations. Hope others will support your work from there too.

@cryham
Copy link
Member

cryham commented Nov 20, 2023

Great, thank you very much for your support.
I will look into these ghost issues soon, if it's something easy to fix (should be) then probably will fix in upcoming Stunt Rally 3.0 beta release (which is now being finalized and tested, we had RC2 binaries recently).

@michael-heerdegen
Copy link
Author

michael-heerdegen commented Nov 22, 2023 via email

@michael-heerdegen
Copy link
Author

  1. Has the Stunt Rally 3.0 beta release happened? How will I be able to try it out - do I have to compile the game myself?

  2. Another relatively low hanging fruit may be: allow the interface to show time deltas relative to the current user ghost instead of the track ghost. This would provide more fun when playing slow cars like OT (I can only play OT because else I get sick. I get even a bit sick with OT but it's still manageable...) Don't want to bother anyone with this, but when someone works on the related code, maybe it's an easy thing, dunno.

@michael-heerdegen
Copy link
Author

Oh, and what I also wanted to say: what would be cool would be a track that would be partly in underwater pipes, and partly on land. There is such a third-party track in Supertuxkart, and it's really very cool and enjoyable.

@cryham
Copy link
Member

cryham commented Jan 26, 2024

  1. Yes Stunt Rally 3.0 was released. Like I wrote here:
    https://stuntrally.tuxfamily.org/downloads
    Windows installer is available. Linux isn't done yet, we're waiting on
    SR 3.1 flathub/org.tuxfamily.StuntRally#15
    If this succeeded then we'd have a flatpak like before. IDK how to do it myself.

  2. Okay could be done. Just needs to drive ghost by game first to determine time at checkpoints.

We already have such tracks with long parts underwater (in pipes too) e.g.
https://stuntrally.tuxfamily.org/tracks3?id=Isl20-Atlantis
https://stuntrally.tuxfamily.org/tracks3?id=Isl21-BarrelFun
https://stuntrally.tuxfamily.org/tracks3?id=Jng26-MilkyWay
There is a challenge "Underwater adventures" with them, in SR3.

@michael-heerdegen
Copy link
Author

michael-heerdegen commented Jan 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants