Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode server config #44

Open
euneuber opened this issue Oct 5, 2020 · 2 comments
Open

Do not hardcode server config #44

euneuber opened this issue Oct 5, 2020 · 2 comments
Labels
api feature request Feature request regarding API design or new APIs without user/moderator frontend documentation Improvements or additions to documentation

Comments

@euneuber
Copy link
Contributor

euneuber commented Oct 5, 2020

in src/serverMain/kotlin/com/studo/campusqr/database/InitialSetup.kt are many settings for the server hardcoded.

These settings do not care about environment vars (HOST, PORT).

Please change to reading server configuration from a file (e.g. yaml)

@vonox7
Copy link
Collaborator

vonox7 commented Oct 5, 2020

Hi, the values in InitialSetup.kt are only the default values. All values can be changed in MongoDB, as described in the "App Configuration" tab when logged into the moderation-frontend as administrator:

All configuration flags that are in the MongoDB database listed in collection "configuration" can be changed by the administrator. Those flags are persisted in the database even across application restarts and updates of this application. Examples for configuration flags are the imprint URL, the base URL for scanning the QR codes or the number of days after the check-in data is automatically deleted. Please contact the Studo team for further assistance or if you need more configuration parameters.

@euneuber
Copy link
Contributor Author

euneuber commented Oct 5, 2020

Server configs for development, testing, demo and production should be

  • easy to set
  • easy to reproduce
  • easy to compare with each other

A test editor should be sufficient.

CI and CD must not require manual intervention by an administrator.

@functionaldude functionaldude added api feature request Feature request regarding API design or new APIs without user/moderator frontend documentation Improvements or additions to documentation labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api feature request Feature request regarding API design or new APIs without user/moderator frontend documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants