Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global JS dependencies vendored from Rails gems #1758

Open
9 of 35 tasks
kevinrobinson opened this issue Jun 4, 2018 · 0 comments
Open
9 of 35 tasks

Remove global JS dependencies vendored from Rails gems #1758

kevinrobinson opened this issue Jun 4, 2018 · 0 comments

Comments

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jun 4, 2018

Follow-on from #1180

This is broken out by different pieces (eg, jQuery plugins).

jquery-ui/autocomplete

jquery-ui/datepicker

Highcharts jQuery API

  • HighchartsWrapper
  • generateReportGraph

Isolate jQuery usage

jQuery data attributes

  • serialized data
  • index.js
  • legacyRouteHandler

jQuery event listeners on document or body

  • ProvidedByEducatorDropdown
  • SliceButtons
  • student_report_pdf.js
  • index.js

DOM querying (html, text, find)

  • ProfilePdfDialog
  • index.js
  • legacyRouteHandler
  • (all the tests)

jquery_ujs

  • CSRF in apiFetchJson
  • Ruby test helpers (simulate_clicking_become_link, educator_sign_in_helper#sign_out)
  • include jquery_ujs in JS build, remove gem

Other bits

  • all the other files imported in legacy.js (Finish ES6 conversion and move tests next to code #1739)
  • all references to window. variables our code put there
  • remove vendored jquery UI gems
  • remove application.js / remove sprockets-shims / remove js gems / remove global in eslintrc
  • move to ui folder

testing notes:

  • student profile pdf
  • storybook
  • service uploads
  • profile v3 and v2
    • updates URL when navigating
    • updates URL when navigating
    • service / notes / transition notes
    • failure for saving notes
    • chart navigating
@kevinrobinson kevinrobinson changed the title Simplify: Remove global JS dependencies vendored from Rails gems Remove global JS dependencies vendored from Rails gems Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant