-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong image dimensions when irot is set #1131
Comments
I believe that file is invalid. ISO/IEC 23008-12:2022 Section 6.5.3.1 requires that |
The cavif code is abandoned so probably not a priority to work around this bug in the producer. |
Those were generated years ago with an early pre-release of https://github.com/kornelski/cavif-rs . Sometimes early apps just aren't complete, even when someone uses them to purport to be authoritative. (Even samples from standards have suffered from this...) A misplaced irot is pretty benign, since it can be fixed so easily by restreaming the boxes or just having an app set a new rotation. |
Interesting. I understood they came from https://github.com/link-u/cavif |
Here is an image for which libheif 1.17 reports wrong dimensions for the primary image. It has width 722 and height 1024 after the correct rotation is applied, but libheif outputs 1024x722.
I believe the problem is here: For some reason the
irot
box appears before theispe
box, and thus line 626, which is supposed to flip the dimensions, is never called.The text was updated successfully, but these errors were encountered: