Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String extraction #126

Open
aastha93 opened this issue Mar 7, 2018 · 6 comments
Open

String extraction #126

aastha93 opened this issue Mar 7, 2018 · 6 comments

Comments

@aastha93
Copy link

aastha93 commented Mar 7, 2018

slt-globalize -e skips string extraction from a file if it sees the method async get.
@raymondfeng
Copy link
Member

strong-globalize uses https://github.com/estools/estraverse to parse the JavaScript source code. I wonder if estraverse is up to date with async/await syntax.

@aastha93
Copy link
Author

aastha93 commented Mar 8, 2018

@raymondfeng The strong-globalize might need to update the dependency

@raymondfeng
Copy link
Member

Unfortunately it already uses the latest version

@Setogit
Copy link
Contributor

Setogit commented Mar 8, 2018 •
edited

@aastha93: update to strong-globalize 3.1.0 or later or update to esprima 4.0.0 ?

@raymondfeng
Copy link
Member

I assume that @aastha93 uses 3.2.0, which already depends on esprima": "^4.0.0", "estraverse": "^4.2.0". I'm afraid that estraverse@4.2.0 does not support async/await.

@raymondfeng
Copy link
Member

I confirm that esprima": "^4.0.0" does support async/await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raymondfeng @Setogit @aastha93