-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort from most specific match when the match is beyond the PSL suffix #754
Comments
Hi @tonyxu-io - This should be fix for you know with 1.59.0 - feel free to reopen if that's not so. |
Wow! That's amazing! Thanks a lot for fixing this so quickly! |
Hi @strongbox-mark, it's very strange, the problem solved for some-sub-domain.grid.linkedin.com when I have password for grid.linkedin.com. But the same issue still exist for some-sub-domain.x.linkedin.com when I have x.linkedin.com password. This is hard to believe. |
Hi @tonyxu-io - Sorry to hear that. Could you please provide the 2 urls that are sorting incorrectly and the url that you are visiting and we can take a look. |
|
Hi @tonyxu-io - I'm afraid I can't reproduce this. Maybe I have your details wrong. Here is what I did: I have 2 entries with the following URLs: and I go to visit: The results are correctly sorted as: What have I done wrong? Could you please supply 2 entry URLs AND the URL you are visiting, AND the result you are seeing? I'm afraid it's not super clear above. |
Actually I'm storing them in the custom URL field (because I have multiple URLs to match for this password): When I directly use the primary URL field it's sorting fine. |
So, that's a fairly important bit of information. Investigating bugs consumes our time and resources. There are other things we can work on, so it's important not to waste time. :) So, if there's still an issue, what I'll need is:
Thanks. |
Entry 1: www.linkedin.com (primary URL) |
Created a new issue to capture the issue we discussed:
In email correspondence we discovered there is a slight bug in sorting of URLs, they're not always sorted from most specific match as they should be when the match is beyond the PSL suffix. e.g.
when visiting https://some-sub-domain.grid.linkedin.com, URL 2 should be sorted as the best match. Currently this isn't the case. We'll work on fixing that. Thanks @tonyxu-io
Originally posted by @strongbox-mark in #743 (comment)
The text was updated successfully, but these errors were encountered: