Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantizer initial state not reflected in umenu #108

Open
isabelgk opened this issue May 17, 2021 · 2 comments
Open

Quantizer initial state not reflected in umenu #108

isabelgk opened this issue May 17, 2021 · 2 comments

Comments

@isabelgk
Copy link
Contributor

When instantiating the Quantizer module, the kslider won't reflect the C Ionian scale until that scale is again selected in the umenu. It may make more sense to have chromatic as the default umenu option or to make the default kslider view be the C Ionian scale.

@stretta
Copy link
Owner

stretta commented May 18, 2021

The current implementation is admittedly confusing. The kslider is the 'working' model, and the umenus are presets that can be loaded onto the kslider. Initializing the quantizer as chromatic may fix the initial problem, but if a preset is selected, and then the kslider is edited, it would be helpful if the umenu displayed itself as dirty in some way to indicate it is not current. I suggest an italicization of a dirty preset.

stretta added a commit that referenced this issue Jun 9, 2021
@stretta
Copy link
Owner

stretta commented Jun 9, 2021

This one should be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants