Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor asUserJson to use Sequelize mode toJSON #2276

Open
easherma opened this issue Mar 4, 2021 · 0 comments
Open

refactor asUserJson to use Sequelize mode toJSON #2276

easherma opened this issue Mar 4, 2021 · 0 comments
Labels
back-end enhancement

Comments

@easherma
Copy link
Collaborator

easherma commented Mar 4, 2021

asUserJson is a utility function that has its roots in our previous MongoDB implementation and does some additional meddling with the user object before sending it off to the client. As to whether or not any of that is necessary or worth refactoring at the moment, these are worthy questions to ponder

Originally posted by @louh in #2274 (comment)
@easherma easherma changed the title Right, so asUserJson is a utility function that has its roots in our previous MongoDB implementation and does some additional meddling with the user object before sending it off to the client. As to whether or not any of that is necessary or worth refactoring at the moment, these are worthy questions to ponder, but certainly not in scope for this PR. refactor asUserJson to use Sequelize mode toJSON Mar 4, 2021
@easherma easherma mentioned this issue Mar 4, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
back-end enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@easherma