Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on an argument for expo and react-native projects #310

Open
grgmgd opened this issue Dec 10, 2021 · 0 comments
Open

Rely on an argument for expo and react-native projects #310

grgmgd opened this issue Dec 10, 2021 · 0 comments

Comments

@grgmgd
Copy link

grgmgd commented Dec 10, 2021

Currently in order to specify which project RNV is running in, we need to install expo or react-native in order for the resolve-from package to import the module and define the project type.

I am using RNV inside an automated github workflow to version my project based on a release tag.
Why not rely on a user defined arg instead. As far as a I understand expo or react-native are not required to make the version updates and we're currently forced to install them to use this package.

Something like this:

$ react-native-version --project-type [expo | react-native] 

Please correct me if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant