Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we open to changing the test file names? #55

Open
binomialstew opened this issue Jun 18, 2018 · 1 comment
Open

Are we open to changing the test file names? #55

binomialstew opened this issue Jun 18, 2018 · 1 comment

Comments

@binomialstew
Copy link

When working on the last PR, I noticed that the test/fixtures file names were not as clear as I would like. For example, the test source files are named actual.js. I would expect these to be named source.js and any generated output to be named actual.js. expected.js would stay the same. This would also allow for an npm command that generates actual.js without overwriting the existing file—enabling easier comparison between the two. If this is something you are open to, I can create a PR—it is basically ready to go.

@danielduan
Copy link
Member

I completely agree all of the above. Maybe even reorganizing the folders and folder names so that they make more sense in terms of grouping too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants