Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical line divider after selecting a date range #251

Open
grantalba opened this issue Nov 11, 2020 · 10 comments · May be fixed by #302
Open

vertical line divider after selecting a date range #251

grantalba opened this issue Nov 11, 2020 · 10 comments · May be fixed by #302

Comments

@grantalba
Copy link

grantalba commented Nov 11, 2020

https://stackoverflow.com/questions/64747135/how-to-remove-the-line-divider-in-the-react-native-calendar-picker-after-selec

See picture in stackoverflow.

@peacechen
Copy link
Collaborator

Haven't seen that before. Are you seeing that on a physical device or the emulator? Which device and/or emulator?

@jingfreeks
Copy link

ios emulator and physical device

@peacechen
Copy link
Collaborator

I apologize for not having time to debug this. Please submit a PR if you find the bug.

@PrabhakarKotipalli
Copy link

dayLabelsWrapper = {{borderWidth:0,borderColor:'white'}}

just add whatever ur background color is to the bordercolor

@pallpointben
Copy link

@PrabhakarKotipalli that is a different issue. Refer to the picture in the attached post.

I am also experiencing this issue. iPhone 11 emulator.

Simulator Screen Shot - iPhone 11 - 2021-04-28 at 22 03 37

@metasection
Copy link

metasection commented May 20, 2021

I see something similar on the Expo Go app running on iOS. Same code works fine with react-native-web which is very cool.

Screen Shot 2021-05-20 at 4 28 37 PM

Here is some test code...

`

return (

  <CalendarPicker
    allowRangeSelection={true}

    minDate={minDate}
    maxDate={maxDate}

    todayBackgroundColor="#f2e6ff"
    selectedDayColor="#7300e6"
    selectedDayTextColor="#FFFFFF"

    onDateChange={_onDateChange}

    disabledDates={disabledDates}
    selectedDisabledDatesTextStyle={{
      color: "#FF0000"
    }}
    disabledDatesTextStyle={{
      color: "#FF00FF"
    }}
  />

</View>

);

`

@rajeshkannanrajagopal
Copy link

Same issue facing in all IOS device alone but in android it works well.

any idea about this?

image

@rayjackson13
Copy link

rayjackson13 commented Sep 8, 2021

This has been open for almost a year now. Is there still no resolution to this?

I'm experiencing the same issue:
image

I'm using react-native-calendar-picker:^7.12. This happens when selecting a range of dates with the following code:

<CalendarPicker allowRangeSelection />

This is all the code you need to be able to repro this issue, then you just need to select a range between two dates.

Upd. I've found that this happens because there's a decimal number specified as the width (for me it was 55.2 on iPhone 11 Sim)

@peacechen
Copy link
Collaborator

peacechen commented Sep 8, 2021

Unfortunately I didn't have time to debug this. It seems to be device/OS specific so I had a difficult time recreating it. Happy to see that @rayjackson13 found the cause. Would you submit a PR to restrict widths to integer values?

Joru-chan added a commit to Joru-chan/CalendarPicker that referenced this issue Oct 12, 2021
@Joru-chan Joru-chan linked a pull request Oct 12, 2021 that will close this issue
@talon-himself
Copy link

@peacechen it looks like a PR has been open for this since October 2021. Any idea when this fix will go in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants