Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"checkAll" column config property #20

Open
Droogans opened this issue Jan 28, 2014 · 3 comments
Open

"checkAll" column config property #20

Droogans opened this issue Jan 28, 2014 · 3 comments

Comments

@Droogans
Copy link
Contributor

When I include a table column config such as the following:

{
        "checkbox": true,
        "checkAll": true
}

I expect the checkbox in the sort column to check/uncheck each row's checkbox.

Currently, it doesn't.

@stephengolub
Copy link
Owner

I think, since I haven't used too much of the check box functionality, I want to refactor the approach on it. Maybe make the checkbox attribute an object like the editable attribute. Thoughts @Droogans?

Maybe something like:

"checkbox" {
  "action": function (row) {...},
  "checkAll": function () {...} // Or a value of true and it will run the action function on each checked row
}

@Droogans
Copy link
Contributor Author

All I can think is that I don't want to bind my checking to an immediate function. I want some other button on my page to iterate over all checked items, and do x to it.

So, given that, it'd be nice if checkboxes didn't have functions bound to them, they would simply check and do nothing. Same goes for checkAll.

@stephengolub
Copy link
Owner

Yea, so I think that putting the configuration for that function, however, would still be in the column declaration.

But definitely make things so that there's a bulk-editing mode or somethinng.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants