Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidybulk Replace pivot_* with select_columns_* #181

Open
stemangiola opened this issue May 6, 2021 · 3 comments
Open

tidybulk Replace pivot_* with select_columns_* #181

stemangiola opened this issue May 6, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@stemangiola
Copy link
Owner

I think subset_transcripts and subset_samples would be more clear and in line with tidyverse. @mblue9 concerns?

@stemangiola stemangiola added the enhancement New feature or request label May 6, 2021
@mblue9
Copy link
Collaborator

mblue9 commented May 6, 2021

I think subset_transcripts and subset_samples would be more clear and in line with tidyverse. @mblue9 concerns?

Nope no concerns just wondering what you mean by it would be more in line with tidyverse?

@stemangiola
Copy link
Owner Author

just wondering what you mean by it would be more in line with tidyverse?

For example, the filter function from dplyr mention the word subset https://dplyr.tidyverse.org/reference/filter.html

Plus subset is more comprehensible by the general audience than pivot, which is a quite abstract term. This is a vocabulary choice, and there is no right answer.

What do you think and user?

@mblue9
Copy link
Collaborator

mblue9 commented May 7, 2021

For example, the filter function from dplyr mention the word subset https://dplyr.tidyverse.org/reference/filter.html

Plus subset is more comprehensible by the general audience than pivot, which is a quite abstract term. This is a vocabulary choice, and there is no right answer.

What do you think and user?

Maybe subset_ is easier to understand. Or in that case why not use select (select_transcripts and select_samples) as it is mainly acting on columns so would select be more in line with tidyverse?

Although I wonder if some might think it's a function for subsetting/selecting transcripts/samples of interest? So could use select_transcript_columns and select_sample_columns to be clear or would that be too long?

But I don't have a strong preference here for pivot/subset/select.

@stemangiola stemangiola changed the title Replace pivot_* with subset_* Replace pivot_* with select_columns_* Aug 31, 2023
@stemangiola stemangiola changed the title Replace pivot_* with select_columns_* tidybulk Replace pivot_* with select_columns_* Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants