Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: consider adding a second app #1

Open
jsdevtom opened this issue Jun 14, 2018 · 3 comments
Open

Suggestion: consider adding a second app #1

jsdevtom opened this issue Jun 14, 2018 · 3 comments

Comments

@jsdevtom
Copy link

Thank you for your time creating this repo!

I suggest creating a second app for this repo so that the real world example is more true to real life. Please consider that one of the main motivations for using a mono repo is to reuse libraries in other apps, and seeing this in practice, I believe, would help users understand how to use nx in a multi application.

What are your opinions regarding my suggestion?
Thanks in advance

@stefanoslig
Copy link
Owner

stefanoslig commented Jun 14, 2018

Hello Tom!
Yes, it's something I really wanted to do but I didn't have enough time for this right now. To be honest my idea was to create a PWA version of the app. What do you think? Could you tell which is your suggestion? I want to upgrade the repo in Angular 6 too! Thank you!

@cristianmartinez
Copy link

Hey @stefanoslig, this is a really good project. Are you still interested in creating the PWA features for this project? let me know if you need help with it. I also want to suggest to use ngrx store facades.
https://medium.com/@thomasburleson_11450/ngrx-facades-better-state-management-82a04b9a1e39
Let me know what do you think.

@stefanoslig
Copy link
Owner

stefanoslig commented Aug 28, 2018

Hello @cristianmartinez. Thank you! Yes It's in my plans to use facades. I uploaded a branch where I refactored the article lib in order to use facades. I have done some other changes too in order to avoid some dependencies between some libs. You can see the corresponding pull request here pr. I will do the same for the other libs in separated branches for each lib.

As for the PWA, the major problem right now is that I don't have mobile-friendly css. And also, I don't believe that the PWA should be a different app. Instead, the main app must be a PWA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants