Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup huge mess in textdocument/linemetainfo interface #205

Open
stefanoborini opened this issue Apr 5, 2015 · 0 comments
Open

Cleanup huge mess in textdocument/linemetainfo interface #205

stefanoborini opened this issue Apr 5, 2015 · 0 comments

Comments

@stefanoborini
Copy link
Owner

The TextDocument/LineMetaInfo interface has grown into a mess due to differences in interface.

Do the following:

  • formalize order of parameters (line_number should go first, last)?
  • formalize selection of intervals as a (start, end) tuple interpreted in python style, instead of start, how_many.
  • change indexing into 0-based (there's already a US about it)
  • make private methods without notifications and public methods with notification, or add a "hold_notification" state to flush all notifications at once (may require signal accumulation pattern in vaitk)
  • cleanup unused or redundant methods. Simplify methods operating on a single line as special cases using the multi-line method.
  • get rid of the charmeta, and find appropriate replacement strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant