Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action #28

Open
edde746 opened this issue Jun 19, 2023 · 6 comments · Fixed by #49
Open

Action #28

edde746 opened this issue Jun 19, 2023 · 6 comments · Fixed by #49

Comments

@edde746
Copy link
Collaborator

edde746 commented Jun 19, 2023

Would be great to have the latest updates of the icon packs, some (especially lucide) are quite outdated at this point. Perhaps even making an Actions job to do this automatically?

@JustinVoitel
Copy link
Contributor

@edde746
yea such a job would be pretty nice to have ^^ Do you have any experience implementing such a Action ?

It would probably just need to parse the current package version from the package.json and check if there is any new version on npm and if so run npm i && npm publish, update changelog and push to github ?

@JustinVoitel
Copy link
Contributor

@edde746 can you test @steeze-ui/lucide-icons@1.1.0 if all is working ?

@edde746
Copy link
Collaborator Author

edde746 commented Jun 19, 2023

@edde746 can you test @steeze-ui/lucide-icons@1.1.0 if all is working ?

Yep, works perfectly.

@edde746 edde746 changed the title Updates Action Jun 19, 2023
@edde746 edde746 mentioned this issue Mar 22, 2024
@JustinVoitel
Copy link
Contributor

@edde746 Regarding the updated npm version of all @steeze-ui/* packages:

What do you think should we

A: inherit the version of the source package, which would be easily implementable via update.py. e.g simple-icons getting updated from version 11.9.0 to 11.11.0 so the @steeze-ui/simple-icons package will be updated from 1.7.1 to 11.11.0. Only Problem would be when we want to manually push a new version (e.g a fix to something)
or
B: go by our own versioning (as it is right now) which will only get patch bumped every time the version of the source package changes ? e.g simple-icons getting updated from version 11.9.0 to 11.11.0 so the @steeze-ui/simple-icons package will be updated from 1.7.1 to 1.7.2. No Problem with manual updates

@JustinVoitel JustinVoitel reopened this Apr 2, 2024
@edde746
Copy link
Collaborator Author

edde746 commented Apr 2, 2024

I think B is the only option because of both the manual update issue as you mentioned and some packages not having source packages which would create an inconsistency where both A and B would be used.

@JustinVoitel
Copy link
Contributor

I also tend to B. Will try to get the action working in the next couple of days 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants