Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade OpenBLAS to v0.3.27 #2236

Merged
merged 2 commits into from May 22, 2024
Merged

chore: upgrade OpenBLAS to v0.3.27 #2236

merged 2 commits into from May 22, 2024

Conversation

rreusser
Copy link
Member

@rreusser rreusser commented May 7, 2024

Resolves #2228

Description

What is the purpose of this pull request?

make install-deps-openblas fails because the OpenBLAS dependency is eight years out of date. By upgrading to OpenBLAS 0.3.27 (latest), the command now succeeds. Though the error can perhaps be ignored, it's nice to minimize friction and failures in the various setup steps.

This pull request:

  • upgrades the openblas version
  • points to the new repository location (OpenMathLib org)
  • updates the checksum
  • adds some missing AVX512 build config

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Are there migration concerns?

No, I think. OpenBLAS support has always been experimental.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

This commit upgrade OpenBLAS from 0.2.19, which is now eight years out
of date, to 0.3.27. Note that OpenBLAS support is experimental in the
first place.

Fixes: #2228
@rreusser rreusser requested a review from kgryte May 7, 2024 22:09
@kgryte kgryte added the Tools Issue or pull request related to project tooling. label May 22, 2024
tools/make/common.mk Outdated Show resolved Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rreusser!

@kgryte kgryte changed the title Upgrade OpenBLAS dependency to 0.3.27 chore: upgrade OpenBLAS to v0.3.27 May 22, 2024
@kgryte kgryte merged commit 0cf2784 into develop May 22, 2024
4 checks passed
@kgryte kgryte deleted the upgrade-openblas branch May 22, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools Issue or pull request related to project tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Upgrade OpenBLAS dependency
2 participants