-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC]: Upgrade OpenBLAS dependency #2228
Comments
@rreusser This would be a welcome addition. And indeed, upgrading OpenBLAS has been a TODO. |
@rreusser I originally based everything on how Julia manages OpenBLAS: https://github.com/JuliaLang/julia/blob/master/deps/openblas.mk |
You can probably cross-reference there to see if we are missing anything in terms of build flags. |
...and no backward compatibility concerns we need to work about. Previous OpenBLAS support via stdlib was always experimental. |
This commit upgrade OpenBLAS from 0.2.19, which is now eight years out of date, to 0.3.27. Note that OpenBLAS support is experimental in the first place. Fixes: #2228
Description
OpenBLAS 0.2.19 is almost eight years out of date.
make install-deps-openblas
. See truncated error logs below:Upgrading to 0.3.27 resulted in successful installation. I propose to upgrade the repo URL, checksum, and version to result in successful OpenBLAS installation.
Related Issues
No response
Questions
Do we need to lock down more build flags along with this? See:
stdlib/tools/make/common.mk
Lines 406 to 480 in 466b5aa
Are there other compatibility issues/concerns/validations which would need to accompany this change?
Other
No.
Checklist
RFC:
.The text was updated successfully, but these errors were encountered: