Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add math/base/special/asinhf #2130

Open
3 tasks done
gunjjoshi opened this issue Apr 6, 2024 · 5 comments
Open
3 tasks done

[RFC]: add math/base/special/asinhf #2130

gunjjoshi opened this issue Apr 6, 2024 · 5 comments
Assignees
@gunjjoshi
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@gunjjoshi
Copy link
Contributor

Description

This RFC proposes adding math/base/special/asinhf, which would be the single-precision equivalent for math/base/special/asinh.

float stdlib_base_asinhf( const float x )

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@gunjjoshi
Copy link
Contributor Author

I would like to work on this.

@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Apr 6, 2024
@gunjjoshi
Copy link
Contributor Author

gunjjoshi commented Apr 6, 2024 •
edited

This requires log1pf, which must be implemented first. Our log1p is based on https://www.netlib.org/fdlibm/s_log1p.c, but I couldn't find the single-precision implementation for it. Is it there ? If not, what source must we then follow for log1pf ?

@gunjjoshi
Copy link
Contributor Author

gunjjoshi commented Apr 6, 2024 •
edited

FreeBSD has log1pf implementation : https://svnweb.freebsd.org/base/release/12.2.0/lib/msun/src/s_log1pf.c?revision=367086&view=markup

@kgryte
Copy link
Member

kgryte commented Apr 6, 2024

Use FreeBSD v12.2.0. Our log1p probably needs to be updated, as I imagine that the fdlibm implementation is somewhat out-of-date.

@gunjjoshi
Copy link
Contributor Author

log1pf, in turn, requires roundf. It isn't needed for the function's implementation, but is required at examples/index.js.
Should I go ahead for roundf ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjjoshi gunjjoshi

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgryte @gunjjoshi