Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Add C implementation for @stdlib/math/base/special/minmax #2106

Open
3 tasks done
anirudhprabhakaran3 opened this issue Apr 1, 2024 · 3 comments
Open
3 tasks done

Comments

@anirudhprabhakaran3
Copy link

Description

This RFC proposes to add a C implementation for @stdlib/math/base/special/minmax

Related Issues

Progresses #649

Questions

  • I note that the implementations of min and max are already available. Should the C implementation exactly follow the logic in the JS files, or could it use the min and max functions in C while maintaining the same function signature and return values?

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte
Copy link
Member

kgryte commented Apr 1, 2024

@anirudhprabhakaran3 Sorry to be the bearer of bad news, but there is already a PR up for minmax: #1939.

@anirudhprabhakaran3
Copy link
Author

Aah😔 seems like I have the worst luck coming to this!

@Aditya8840
Copy link

@kgryte I'd like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants