Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: improve type declarations for @stdlib/utils/map-arguments #1087

Open
3 tasks done
kgryte opened this issue Aug 22, 2023 · 5 comments · May be fixed by #2050
Open
3 tasks done

[RFC]: improve type declarations for @stdlib/utils/map-arguments #1087

kgryte opened this issue Aug 22, 2023 · 5 comments · May be fixed by #2050
Assignees
@iItachiUchiha
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Enhancement Issue or pull request for enhancing existing functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. TypeScript Issue involves or relates to TypeScript.

Comments

@kgryte
Copy link
Member

kgryte commented Aug 22, 2023

Description

This RFC proposes improving the TypeScript type declarations for @stdlib/utils/map-arguments. Currently, considerable type information is lost when using this function.

Ideally, we'd improve declarations for the input and callback functions and the thisArg.

Related Issues

No.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. RFC Request for comments. Feature requests and proposed changes. TypeScript Issue involves or relates to TypeScript. labels Aug 22, 2023
@iItachiUchiha
Copy link

i have started to work on this issue please assign this issue to me.

@kgryte
Copy link
Member Author

kgryte commented Feb 22, 2024

Thanks for volunteering to work on this @iItachiUchiha. Please feel free to submit a PR with your proposed updates to the declarations for this package.

@iItachiUchiha
Copy link

Thanks for volunteering to work on this @iItachiUchiha. Please feel free to submit a PR with your proposed updates to the declarations for this package.

thanks @kgryte i will make pr probably tomorrow.

@kgryte kgryte added Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Feb 23, 2024
@iItachiUchiha
Copy link

iItachiUchiha commented Feb 26, 2024 •
edited

@kgryte as i studied in codebase the fcn will be array of type : any, clbk : (value: any, index:number ) and thisArg will be of any type. are these correct ? if not then can you give some suggestions ?

@iItachiUchiha
Copy link

@kgryte ?

@prajwalkulkarni prajwalkulkarni linked a pull request Mar 26, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iItachiUchiha iItachiUchiha

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Enhancement Issue or pull request for enhancing existing functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. TypeScript Issue involves or relates to TypeScript.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve type declarations for utils/map-arguments prajwalkulkarni/stdlib
2 participants
@kgryte @iItachiUchiha