Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/*#__PURE__*/ annotations don't play well with Vite / Rollup #207

Open
shellscape opened this issue Dec 1, 2023 · 3 comments
Open

/*#__PURE__*/ annotations don't play well with Vite / Rollup #207

shellscape opened this issue Dec 1, 2023 · 3 comments

Comments

@shellscape
Copy link

It looks like the build script for this lib is outputting code which contains /*#__PURE__*/ annotation comments. Unfortunately they look like they're misplaced, and we're getting some non-blocking warnings about it. Here's what the warnings look like when compiling an app which uses this lib, with Vite:

"/*#__PURE__*/"

in "../../node_modules/.pnpm/react-helmet-async@1.3.0_react-dom@18.2.0_react@18.2.0/node_modules/react-helmet-async/lib/index.module.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
../../node_modules/.pnpm/react-helmet-async@1.3.0_react-dom@18.2.0_react@18.2.0/node_modules/react-helmet-async/lib/index.module.js (1:13561) A comment

"/*#__PURE__*/"

in "../../node_modules/.pnpm/react-helmet-async@1.3.0_react-dom@18.2.0_react@18.2.0/node_modules/react-helmet-async/lib/index.module.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
@goliney
Copy link

goliney commented Feb 28, 2024

It's time to look for alternative libs. Any suggestions? :)

@thienandangthanh
Copy link

thienandangthanh commented Feb 28, 2024

The warning disappears from version 2.0.0.
Because the lib switched to use esbuild.
You can give it a try.

Here's the diff: b1ee658...a75c3ae

@goliney
Copy link

goliney commented Feb 28, 2024

@thienandangthanh thank you for the response. If true, this issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants