Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better threat different offchain signed votes for same proposal #7

Open
3esmit opened this issue Mar 27, 2019 · 0 comments
Open

Better threat different offchain signed votes for same proposal #7

3esmit opened this issue Mar 27, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@3esmit
Copy link
Member

3esmit commented Mar 27, 2019

Currently, signed votes are included with no verification to reduce the cost. This should stay as it is.

The problem with this is that it allows a voter to submit 2 different votes, and the tabulation would get into a race condition.

Currently the first tabulated would be the accepted. The retabulation is prevented by this line:

require(voteMap[_voter] == Vote.Null, "Already voted");

This is a problem because delegates could vote for something and later change their minds, making community not be able to quickly follow their actions. Also putting the tabulation in a unpredictable outcome for that account influence (and delegated influence).

Its not a security problem, however it can help delegates to mislead their vote at votingPeriod.

A option would be to burn the vote (or make it a blank vote). The problem is if there is already indirect influence claimed.

@3esmit 3esmit added enhancement New feature or request question Further information is requested labels Mar 27, 2019
@3esmit 3esmit self-assigned this Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant