Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading screen for fetching community #19555

Closed
clauxx opened this issue Apr 5, 2024 · 5 comments · Fixed by #19968
Closed

Fix loading screen for fetching community #19555

clauxx opened this issue Apr 5, 2024 · 5 comments · Fixed by #19968

Comments

@clauxx
Copy link
Member

clauxx commented Apr 5, 2024

Dependent on designs for loading illustration for fetching the community.

Bug Report

Remove the red square around fetching community when opening a newly shared community. Discuss with the design team or just make it somewhat presentable. Maybe add a button to cancel in case it takes too long or is stuck. Currently there seem to be no designs for this.

@ibrkhalil
Copy link
Contributor

@Francesca-G Do you have designs ready for this state?

@clauxx
Copy link
Member Author

clauxx commented Apr 19, 2024

I don't think there's designs for this, but we could remove the red box and add a button to cancel or go back for now. In case the illustrations are not ready, we can add them later on.

NOTE: We could also add the cat-in-box illustration to make it less jarring until the real illustrations are ready.

@Parveshdhull
Copy link
Member

image

@seanstrom Please can you confirm if this issue is addressed?

@seanstrom
Copy link
Member

Hey @Parveshdhull 👋
I don't think the issues has been addressed yet. I think we're waiting for some official designs / illustrations, but I think it's been discussed that we can make a temporary screen that looks better than the current red box with text. For example, we could re-use some assets from our other screens that have empty or pending states.

@clauxx did you start some of this already? I remember us looking at the different cat images 😸

@clauxx
Copy link
Member Author

clauxx commented May 8, 2024

@seanstrom no I didn't. I guess any solution works for now, but most important is to get rid of the red square around the text. Would be nicer if it's pretty tho 🐱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment