Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple suggestedRoutes from marketManager.FetchPrices #5103

Open
IvanBelyakoff opened this issue Apr 30, 2024 · 0 comments
Open

Decouple suggestedRoutes from marketManager.FetchPrices #5103

IvanBelyakoff opened this issue Apr 30, 2024 · 0 comments

Comments

@IvanBelyakoff
Copy link
Contributor

Problem

Currently in router's suggestedRoutes we call marketManager.FetchPrices to get fiat values and return them, but if market providers fail (conigecko, cryptocompare), we receive no routes error, though we actually can get routes, just not fiat values for the fees. We should separate the logic and make an extra call from client side for the fees values or at least do not consider market providers failure as a blocker error.

Acceptance Criteria

Suggested routes must be returned independently of market providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Iteration Backlog
Development

No branches or pull requests

3 participants