Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite tests that use infura requests #5087

Open
igor-sirotin opened this issue Apr 24, 2024 · 2 comments
Open

Rewrite tests that use infura requests #5087

igor-sirotin opened this issue Apr 24, 2024 · 2 comments

Comments

@igor-sirotin
Copy link
Contributor

We shouln't make infura requests during status-go tests.
For now they're skipped: #5086
@igor-sirotin igor-sirotin mentioned this issue Apr 24, 2024
Merged
@stefandunca stefandunca mentioned this issue Apr 24, 2024
Closed
@supragya
Copy link

Shouldn't this be closed? Since #5086 is merged? @igor-sirotin

@igor-sirotin
Copy link
Contributor Author

Shouldn't this be closed? Since #5086 is merged? @igor-sirotin

Not really. #5086 was a hotfix to make tests working again, i.e. just skip them. We should rewrite those tests in a proper way, this is what the issue is about now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@supragya @igor-sirotin