-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly tests are run with outdated /_assets/scripts/run_unit_tests.sh
#4993
Comments
I've rerun the same Hm, it ran on a bit newer commit unfortunately - But newer build doesn't have these iterations too: Looks like an issue with |
Workdir is Iteration output was added in a068b64 |
|
what the heck?
So they are both stuck in the past. |
|
Checkout log from
|
Running these commands manually changed the commit succesfully.
|
stdout/stdin of git commands is not printed unfortunately: |
New build succesfully checked out, but maybe because I did fetch. |
Wow, interesting thing! https://ci.status.im/job/status-go/job/tests-nightly/171/ changed from |
https://ci.status.im/job/status-go/job/tests-nightly/172
this one:
|
That's the code checking out incorrectly: status-go/_assets/scripts/migration_check.sh Lines 21 to 23 in 98c3be5
|
@andremedeiros, @osmaczko, please have a look |
According to Andrea:
But changing the locally checked out branch is the wrong way to do this. We either need a separate checkout(slow) or use the ability of |
Oh, I see, nice catch @yakimant 🙏 |
Wouldn't |
Will the fix take a long time? Is it worth to disable this functionality meanwhile? |
The fix is most probably just to use:
So it doesn't change the branch, just checks out |
And of course clean it up after the check is performed. |
git fetch origin develop is what we had before, git checkout origin/develop -- protocol/migrations/sqlite Not sure that makes sense, we want to check against develop, so we don't need to checkout those files. One thing I don't understand, 1) Why the nightly tests run migration checks (or do they?) or 2) Are we sharing workspaces and is PR impacting this? If the nightly run is runing migration check, it should not as it doesn't make sense, if it's PR impacting this, then I guess is a different story. If anyone wants to try to see why git fetch origin develop didn't work, that's also great |
To check if #4993 is really resolved.
To check if #4993 is really resolved.
To check if #4993 is really resolved.
Nightly tests are run with outdated
/_assets/scripts/run_unit_tests.sh
.https://ci.status.im/job/status-go/job/tests-nightly/167/execution/node/72/log/
In this certain build,
g show 2aa306ef4:./_assets/scripts/run_unit_tests.sh
script should also print theIteration
info, but it doesn't. Expected output is:The text was updated successfully, but these errors were encountered: