Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nim 2.0 version testing #165

Open
etan-status opened this issue Feb 13, 2024 · 1 comment
Open

Nim 2.0 version testing #165

etan-status opened this issue Feb 13, 2024 · 1 comment

Comments

@etan-status
Copy link
Contributor

It would be great if some of the Nimbus deployments would be compiled using Nim upstream/version-2-0 with --mm:refc instead of the default 1.6 version. upstream/version-2-0 has been stable as far as compilation is concerned for quite a while now.

Right now, especially on Windows there still are issues with multithreading, so expecting instability there. Seeing that confirmed on the fleet as well, and seeing whether macOS / Linux exhibit issues would be great to track when things improve. Problem visible in eg https://github.com/cheatfate/nimcrypto/actions/runs/7306516072/job/19911286657

Have to make sure to use NIM_COMMIT=upstream/version-2-0 instead of just version-2-0 because sometimes people push outdated version-2-0 branch to origin (status-im fork). The Nim build script adds a second remote upstream that tracks nim-lang repo. Can also see nimbus-eth2 CI for the config. And, the --mm:refc needs to be passed as well from 2.0 onward as the default got changed to orc. It's fine to also pass --mm:refc to 1.6 but there it's a nop as it's already the default.

@tersec
Copy link

tersec commented Feb 22, 2024

#167 but didn't check whether it gets --mm:refc correct. Depending on how it's built, this is part of https://github.com/status-im/nimbus-eth2/blob/c5cb0ea3f6ec0ad3af76524ea7ec0eb1da0b973d/config.nims#L139

--mm:refc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants