Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Librato "stat level tags" #258

Open
CloudNiner opened this issue Jun 5, 2017 · 1 comment
Open

Support Librato "stat level tags" #258

CloudNiner opened this issue Jun 5, 2017 · 1 comment

Comments

@CloudNiner
Copy link

CloudNiner commented Jun 5, 2017

It appears that its not currently possible to create a tag of the form:

my.metric#service=web,app_version=1.12:42

and have it passed on to Librato via statsite and the built-in Librato sink. Librato's statsd plugin states that "in order to use tags, the statsd config option keyNameSanitize must be set to false to properly parse tags out of your stat name." In order to support this feature in statsite, it seems that two changes are necessary:

  1. Update the statsite configuration to support a parameter similar to keyNameSanitize.
  2. Update the statsite Librato sink to support sending tagged metrics. Tags don't appear to be parsed from the keys sent to the sink.

See:

@bryanmikaelian
Copy link
Contributor

Thanks for bringing this up @CloudNiner. Librato currently has a fork with updates to our sink here:

https://github.com/librato/statsite/blob/master/sinks/librato.py

We are still rolling tags out to more customers but do plan to merge our changes upstream in the near future. @jderrett can be your point person if you have any issues with the sink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants