Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0 release tarball has several references to version 0.7.1 #237

Open
drawks opened this issue Apr 21, 2017 · 3 comments
Open

0.8.0 release tarball has several references to version 0.7.1 #237

drawks opened this issue Apr 21, 2017 · 3 comments
Labels
Milestone

Comments

@drawks
Copy link
Contributor

drawks commented Apr 21, 2017

Just like the subject says. It seems the 0.8.0 release here on github isn't actually versioned as such internally.

$ fgrep -r '0.7.1' *
CHANGELOG.md:# 0.7.1
configure.ac:AC_INIT([Statsite], [0.7.1])
deps/check-0.9.8/NEWS:Wed Jul 30, 2001: Released Check 0.7.1
rpm/statsite.spec:Version:      0.7.1
rpm/statsite.spec:* Tue May 12 2015 Yann Ramin <yann@twitter.com> - 0.7.1-1
@johnkeates
Copy link
Contributor

johnkeates commented Apr 21, 2017

The changelog should contain the older version as it is part the older changelog messages. In the check directory you are referring to a news file from the check library, not related to statsite,
but the rpm subdirectory has not been updated indeed. The configure.ac has 0.8.0 in the repo: https://github.com/statsite/statsite/blob/master/configure.ac#L6

It seems that the original author released 0.8.0 but didn't change configure.ac and the rpm spec file. We should fix that in 0.8.1.

@drawks
Copy link
Contributor Author

drawks commented Apr 21, 2017

In the meantime the 0.8.0 "release" builds "0.7.1" which seems not very "releasy" ;)

@johnkeates johnkeates added the bug label May 5, 2017
@johnkeates
Copy link
Contributor

Looking back at this issue, it seems only one item was actually wrong:

configure.ac:AC_INIT([Statsite], [0.7.1])

The rest are changelogs which would contain previous versions too, except maybe for the .spec file. We should probably document what to edit in some sort of release guideline so that the version numbers are bumped correctly. I'd prefer just setting the version in configure.ac and have autotools parse all files that need to have a version reference set, but for packaging systems I'm not so sure that'll work well. (since at least with Debian a packaging-version is appended)

@johnkeates johnkeates added this to the 0.8.1 milestone May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants